Open SgtPooki opened 11 months ago
Note that when changing the CI to use the CLI commands, the plugin is loaded properly: https://github.com/ipfs/ipfs-desktop/actions/runs/6565554763/job/17835204060#step:5:17.
The line in the output above is emitted by https://github.com/ipfs-shipyard/release-please-ipfs-plugin/blob/a5529f51b3d2ca8907387e395745a85f6352ed1a/src/index.ts#L10
AFAIK, release-please (or the action) cannot dynamically load plugins from other packages. This was something I was looking into but is not implemented.
AFAIK, release-please (or the action) cannot dynamically load plugins from other packages. This was something I was looking into but is not implemented.
If the plugin is a dependency of the package release-please is running against (ie in node_modules), or even pulled in during CI workflow, release-please should be able to require it the same as the CLI.
TL;DR
Custom plugins that are loaded by the CLI tool are not loaded by the release-please action.
The
release-please-action
should allow for users to specify custom release-please plugins without requiring them to call the release-please CLI directly.Detailed design
There are already config options available to specify release-please plugins, so the tool is aware of them, however, the execution runtime is not the same as the release-please binary which will
require
plugins that are known to it.There are a few different paths forward:
require
"unknown" types before emittingConfigurationError
srequire
any plugins passed to release-please-action, similar to the release-please CLI. This is possibly BREAKING for existing release-please-action users?Additional information
See https://github.com/ipfs-shipyard/release-please-ipfs-plugin#ensure-you-call-the-release-please-binary for more details, but basically:
This results in errors like that seen at https://github.com/ipfs/ipfs-desktop/actions/runs/6506161278/job/17671766024#step:2:913