search

googleapis / release-please-action

automated releases based on conventional commits
Apache License 2.0
1.64k stars 207 forks source link

Extra files are not updated #879

Closed gabrik closed 9 months ago

gabrik commented 9 months ago

TL;DR

Added extra files in release please configuration but they are not updated in the PRthe

Expected behavior

The specified files are updated

Observed behavior

Only the Cargo.toml is updated

Action YAML

name: release-please
on:
  push:
    branches:
      - main

permissions:
  contents: write
  pull-requests: write

jobs:
  checks:
      name: Checks
      runs-on: ubuntu-latest
      steps:
        - uses: actions/checkout@v4

        - name: Install depdendencies
          run: |
            sudo apt update
            sudo apt install -y protobuf-compiler

        - name: Install Rust toolchain
          run: |
              rustup show
              rustup component add rustfmt clippy

        - name: Code format check
          uses: actions-rs/cargo@v1
          with:
            command: fmt
            args: -- --check

        - name: Unit tests
          uses: actions-rs/cargo@v1
          with:
            command: test
            args: --all

        - name: Clippy
          uses: actions-rs/cargo@v1
          with:
            command: clippy
            args: --all-targets -- -D warnings

        - name: Clippy unstable
          uses: actions-rs/cargo@v1
          with:
            command: clippy
            args: --all-targets -- -D warnings

        - name: Clean up
          uses: actions-rs/cargo@v1
          with:
            command: clean

  release-please:
    name: release
    needs: [checks]
    runs-on: ubuntu-latest
    steps:
      - uses: google-github-actions/release-please-action@v3
        id: release
        with:
          release-type: rust
          config-file: release-please-config.json
          # pull-request-title-pattern: "chore${scope}: release${component} ${version}"
          # token: ${{secrets.PAT_TOKEN}}
    outputs:
        release_created:  ${{ steps.release.outputs.release_created }}
        tag_name: ${{ steps.release.outputs.tag_name }}
        upload_url: ${{ steps.release.outputs.upload_url }}

  publish-js:
    runs-on: ubuntu-latest
    if: ${{ needs.release-please.outputs.release_created }}
    needs: [release-please]
    steps:
      # The logic below handles the npm publication:
      - name: Checkout Repository
        uses: actions/checkout@v4
      - name: Setup Node
        uses: actions/setup-node@v4
        with:
          node-version: 20
      - name: build
        run: |
            cd clients/nodejs
            yarn run release

  publish-py:
    runs-on: ubuntu-latest
    needs: [release-please]
    if: ${{ needs.release-please.outputs.release_created }}
    steps:
      - name: Checkout Repository
        uses: actions/checkout@v4
      - name: Get version
        id: get_version
        run: echo  ${{ needs.release-plase.outputs.tag_name }} | sed -nre 's/^[^0-9]*(([0-9]+\.)*[0-9]+).*/\1/p'  >> "$GITHUB_OUTPUT"
      - uses: actions/setup-python@v4
        with:
          python-version: '3.10' 
      - name: install dependency
        run: pip3 install build wheel setuptools -y
      - name: build
        run: |
          cd clients/python
          python3 -m build --wheel

      - name: upload windows artifact
        uses: actions/upload-release-asset@v1
        env:
          GITHUB_TOKEN: ${{ github.token }}
        with:
          upload_url: ${{ needs.release-plase.outputs.upload_url }}
          asset_path: clients/python/dist/release_learning-${{ steps.get_version.outputs.output1 }}-py3-none-any.whl
          asset_name: release_learning--${{ steps.get_version.outputs.output1 }}-py3-none-any.whl
          asset_content_type: application/zip

Log output

2023-11-29T18:17:10.5520284Z ##[group]Run google-github-actions/release-please-action@v3
2023-11-29T18:17:10.5521012Z with:
2023-11-29T18:17:10.5521396Z   release-type: rust
2023-11-29T18:17:10.5522048Z   config-file: release-please-config.json
2023-11-29T18:17:10.5522812Z   token: ***
2023-11-29T18:17:10.5523186Z   fork: false
2023-11-29T18:17:10.5523635Z   clean: true
2023-11-29T18:17:10.5523993Z   bump-minor-pre-major: false
2023-11-29T18:17:10.5524536Z   bump-patch-for-minor-pre-major: false
2023-11-29T18:17:10.5525193Z   changelog-host: https://github.com
2023-11-29T18:17:10.5525813Z   github-api-url: https://api.github.com
2023-11-29T18:17:10.5526461Z   github-graphql-url: https://api.github.com/graphql
2023-11-29T18:17:10.5527147Z   monorepo-tags: false
2023-11-29T18:17:10.5527581Z ##[endgroup]
2023-11-29T18:17:11.0686578Z ❯ Fetching Cargo.toml from branch main
2023-11-29T18:17:11.3188991Z ✔ Looking for latest release on branch: main with prefix: release-test
2023-11-29T18:17:11.3191111Z ❯ Fetching merge commits on branch main with cursor: undefined
2023-11-29T18:17:11.6464907Z ❯ Fetching releases with cursor undefined
2023-11-29T18:17:11.8134882Z ⚠ Could not find releases.
2023-11-29T18:17:11.8141706Z ❯ found 0 possible releases. []
2023-11-29T18:17:11.9363808Z ❯ found 0 possible tags. []
2023-11-29T18:17:11.9367978Z ✔ Building releases
2023-11-29T18:17:11.9369223Z ✔ Building strategies by path
2023-11-29T18:17:11.9370766Z ❯ .: rust
2023-11-29T18:17:12.2184092Z ❯ Fetching Cargo.toml from branch main
2023-11-29T18:17:12.2185550Z ✔ Looking for latest release on branch: main with prefix: release-test
2023-11-29T18:17:12.2186625Z ❯ Fetching merge commits on branch main with cursor: undefined
2023-11-29T18:17:12.5670351Z ❯ Fetching releases with cursor undefined
2023-11-29T18:17:12.7402782Z ⚠ Could not find releases.
2023-11-29T18:17:12.7403608Z ❯ found 0 possible releases. []
2023-11-29T18:17:12.8593419Z ❯ found 0 possible tags. []
2023-11-29T18:17:12.8598234Z ✔ Building pull requests
2023-11-29T18:17:12.8599056Z ✔ Building strategies by path
2023-11-29T18:17:12.8599661Z ❯ .: rust
2023-11-29T18:17:12.8600648Z ✔ Collecting release commit SHAs
2023-11-29T18:17:12.8601419Z ❯ release search depth: 400
2023-11-29T18:17:12.8601920Z ❯ Fetching releases with cursor undefined
2023-11-29T18:17:13.0454167Z ⚠ Could not find releases.
2023-11-29T18:17:13.0455361Z ⚠ Expected 1 releases, only found 0
2023-11-29T18:17:13.0456259Z ⚠ Missing 1 paths: .
2023-11-29T18:17:13.1516999Z ⚠ No version for path .
2023-11-29T18:17:13.1517752Z ⚠ Expected 1 releases, only found 0
2023-11-29T18:17:13.1519304Z ✔ Collecting commits since all latest releases
2023-11-29T18:17:13.1520069Z ❯ commit search depth: 500
2023-11-29T18:17:13.1520620Z ❯ Set(0) {}
2023-11-29T18:17:13.1521270Z ❯ Fetching merge commits on branch main with cursor: undefined
2023-11-29T18:17:13.4850204Z ❯ Backfilling file list for commit: d17769cae89f5af882c5bc3607db4bae16fe2c91
2023-11-29T18:17:13.6731940Z ❯ Found 1 files
2023-11-29T18:17:13.6733364Z ❯ Backfilling file list for commit: b2c4cd5f926c02677a1bb6f21a89b8196e5368db
2023-11-29T18:17:13.8342156Z ❯ Found 5 files
2023-11-29T18:17:13.8343223Z ❯ Backfilling file list for commit: 2c40088bc85ae218001d5e4d2e0cab655b42e869
2023-11-29T18:17:13.9969821Z ❯ Found 0 files
2023-11-29T18:17:13.9970844Z ❯ Backfilling file list for commit: 633828cf30c6baff61ab1d0787a02ed989695ad4
2023-11-29T18:17:14.1529798Z ❯ Found 11 files
2023-11-29T18:17:14.1530481Z ✔ Splitting 4 commits by path
2023-11-29T18:17:14.1536043Z ✔ Building candidate release pull request for path: .
2023-11-29T18:17:14.1536694Z ❯ type: rust
2023-11-29T18:17:14.1537019Z ❯ targetBranch: main
2023-11-29T18:17:14.1574453Z ⚠ No latest release pull request found.
2023-11-29T18:17:14.1575384Z ❯ commit could not be parsed: 633828cf30c6baff61ab1d0787a02ed989695ad4 initial
2023-11-29T18:17:14.1576302Z ❯ commits: 7
2023-11-29T18:17:14.1576813Z ✔ Considering: 7 commits
2023-11-29T18:17:14.1579537Z ❯ component: 
2023-11-29T18:17:14.1581487Z ❯ pull request title pattern: undefined
2023-11-29T18:17:14.1584059Z ❯ Fetching Cargo.toml from branch main
2023-11-29T18:17:14.1974217Z ✔ single crate found, updating Cargo.toml
2023-11-29T18:17:14.4483402Z ✔ Looking for open release pull requests
2023-11-29T18:17:14.6027110Z ✔ found 1 open release pull requests.
2023-11-29T18:17:14.6028451Z ✔ Looking for snoozed release pull requests
2023-11-29T18:17:14.8486653Z ✔ found 0 snoozed release pull requests.
2023-11-29T18:17:14.8490206Z ❯ Fetching CHANGELOG.md from branch main
2023-11-29T18:17:14.8492975Z ❯ Fetching Cargo.toml from branch main
2023-11-29T18:17:14.8502476Z ❯ Fetching Cargo.lock from branch main
2023-11-29T18:17:14.8503340Z ⚠ file Cargo.lock did not exist
2023-11-29T18:17:14.8503916Z ❯ Fetching .release-please-manifest.json from branch main
2023-11-29T18:17:14.9517821Z ✔ Starting GitHub PR workflow...
2023-11-29T18:17:15.0752846Z ✔ Successfully found branch HEAD sha "d17769cae89f5af882c5bc3607db4bae16fe2c91".
2023-11-29T18:17:15.1744656Z ✔ Skipping branch creation step...
2023-11-29T18:17:15.3066354Z ✔ Got the latest commit tree
2023-11-29T18:17:15.4747902Z ✔ Successfully created a tree with the desired changes with SHA 559996d010401f8b8c5218ec5aa304bf48c47d25
2023-11-29T18:17:15.7025668Z ✔ Successfully created commit. See commit at https://api.github.com/repos/gabrik/release-learning-2/git/commits/c3c6604fc5584488880bd2af4de117c75a77961a
2023-11-29T18:17:15.7027605Z ✔ Updating reference heads/release-please--branches--main--components--release-test to c3c6604fc5584488880bd2af4de117c75a77961a
2023-11-29T18:17:16.0114681Z ✔ Successfully updated reference release-please--branches--main--components--release-test to c3c6604fc5584488880bd2af4de117c75a77961a
2023-11-29T18:17:16.1898149Z ✔ Found existing pull request for reference gabrik:release-please--branches--main--components--release-test. Skipping creating a new pull request.
2023-11-29T18:17:16.1899549Z ✔ Successfully opened pull request: 5.

Additional information

I may be messing with the path definition in the release please config, but doc is not clear.

I'm testing on a dummy repo: https://github.com/gabrik/release-learning-2

release-please-config.json

{
    "extra-files": [
        {
            "type":"json",
            "path":"clients/nodejs/package.json",
            "jsonpath": "$.version"
        },
        {
            "type":"toml",
            "path":"clients/python/pyproject.toml",
            "jsonpath": "$.project.version"
        }
    ],
    "$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json"
}
chingor13 commented 9 months ago

In v3 of the action, release-type and manifest-config do not work together -- you either configure via action inputs (in v3 of the action) or configure in the manifest file. In v3, you should set the command option to manifest if you want to use the manifest config file.

Also, make sure you configure package paths in your release-please-config.json

{
    "release-type": "rust",
    "extra-files": [
        {
            "type":"json",
            "path":"clients/nodejs/package.json",
            "jsonpath": "$.version"
        },
        {
            "type":"toml",
            "path":"clients/python/pyproject.toml",
            "jsonpath": "$.project.version"
        }
    ],
    "packages": {
        ".": {}
    },
    "$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json"
}

Note that in v4 (releasing soon), you won't be able do make any advanced customization features via the action yaml and will need to use the release-please-config.

gabrik commented 9 months ago

Hi @chingor13, that indeed solved the issue But now when trying to use the cargo-workspace plugin in the release-please-config.json the extra files are not updated anymore.

release-please-config.json

{
    "release-type": "rust",
    "plugins": ["cargo-workspace"],
    "extra-files": [
        {
            "type":"json",
            "path":"clients/nodejs/package.json",
            "jsonpath": "$.version"
        },
        {
            "type":"toml",
            "path":"clients/python/pyproject.toml",
            "jsonpath": "$.project.version"
        }
    ],
    "packages": {
        ".": {},
        "release-test":{},
        "a-crate":{},
        "b-crate":{}
    },
    "pull-request-title-pattern":"chore${scope}: release${component} ${version}",
    "release-label": "Release Learning",
    "$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json"
}

action log

2023-12-06T11:53:34.7817562Z ##[group]Run google-github-actions/release-please-action@v3
2023-12-06T11:53:34.7818210Z with:
2023-12-06T11:53:34.7818540Z   command: manifest
2023-12-06T11:53:34.7819005Z   config-file: release-please-config.json
2023-12-06T11:53:34.7819669Z   token: ***
2023-12-06T11:53:34.7819983Z   fork: false
2023-12-06T11:53:34.7820381Z   clean: true
2023-12-06T11:53:34.7820734Z   bump-minor-pre-major: false
2023-12-06T11:53:34.7821123Z   bump-patch-for-minor-pre-major: false
2023-12-06T11:53:34.7821644Z   changelog-host: https://github.com
2023-12-06T11:53:34.7822143Z   github-api-url: https://api.github.com
2023-12-06T11:53:34.7822619Z   github-graphql-url: https://api.github.com/graphql
2023-12-06T11:53:34.7823191Z   monorepo-tags: false
2023-12-06T11:53:34.7823601Z ##[endgroup]
2023-12-06T11:53:35.5035672Z ❯ Fetching release-please-config.json from branch main
2023-12-06T11:53:35.5036501Z ❯ Fetching .release-please-manifest.json from branch main
2023-12-06T11:53:36.1242769Z ✔ Building releases
2023-12-06T11:53:36.1243714Z ✔ Building strategies by path
2023-12-06T11:53:36.1244703Z ❯ .: rust
2023-12-06T11:53:36.1245283Z ❯ release-test: rust
2023-12-06T11:53:36.1245982Z ❯ a-crate: rust
2023-12-06T11:53:36.1246757Z ❯ b-crate: rust
2023-12-06T11:53:37.3829817Z ❯ Fetching release-please-config.json from branch main
2023-12-06T11:53:37.3833341Z ❯ Fetching .release-please-manifest.json from branch main
2023-12-06T11:53:37.3838072Z ✔ Building pull requests
2023-12-06T11:53:37.3839484Z ✔ Building strategies by path
2023-12-06T11:53:37.3840346Z ❯ .: rust
2023-12-06T11:53:37.3846767Z ❯ release-test: rust
2023-12-06T11:53:37.3857031Z ❯ a-crate: rust
2023-12-06T11:53:37.3857979Z ❯ b-crate: rust
2023-12-06T11:53:37.3858651Z ❯ Fetching Cargo.toml from branch main
2023-12-06T11:53:37.6894728Z ❯ Fetching release-test/Cargo.toml from branch main
2023-12-06T11:53:37.9674814Z ❯ Fetching a-crate/Cargo.toml from branch main
2023-12-06T11:53:38.3379210Z ❯ Fetching b-crate/Cargo.toml from branch main
2023-12-06T11:53:38.6375339Z ✔ Collecting release commit SHAs
2023-12-06T11:53:38.6377506Z ❯ release search depth: 400
2023-12-06T11:53:38.6378966Z ❯ Fetching releases with cursor undefined
2023-12-06T11:53:39.1174475Z ❯ Found release for path release-test, release-test-v0.2.23
2023-12-06T11:53:39.1178100Z ⚠ Expected 4 releases, only found 1
2023-12-06T11:53:39.1179941Z ⚠ Missing 3 paths: .,a-crate,b-crate
2023-12-06T11:53:39.4196920Z ⚠ Expected 4 releases, only found 1
2023-12-06T11:53:39.4203365Z ❯ looking for tagName: v0.2.23
2023-12-06T11:53:39.4204858Z ❯ looking for tagName: a-crate-v0.2.23
2023-12-06T11:53:39.4205914Z ❯ looking for tagName: b-crate-v0.2.23
2023-12-06T11:53:39.4207330Z ❯ release for path: release-test, version: 0.2.23, sha: a6e3ed34fbfb2cf140f92ab23bf480a2e2f92040
2023-12-06T11:53:39.4208755Z ✔ Collecting commits since all latest releases
2023-12-06T11:53:39.4209729Z ❯ commit search depth: 500
2023-12-06T11:53:39.4214719Z ❯ Set(1) { 'a6e3ed34fbfb2cf140f92ab23bf480a2e2f92040' }
2023-12-06T11:53:39.4216786Z ❯ Fetching merge commits on branch main with cursor: undefined
2023-12-06T11:53:40.8851093Z ❯ Backfilling file list for commit: 197392a592e184e14fe596da2797444d14d4bed0
2023-12-06T11:53:41.2545033Z ❯ Found 9 files
2023-12-06T11:53:41.2545792Z ❯ Backfilling file list for commit: 2d8c3e9bfa19187284d5b59d3528735d06f15d64
2023-12-06T11:53:41.5401276Z ❯ Found 2 files
2023-12-06T11:53:41.5402245Z ❯ Backfilling file list for commit: 280182d7fda39b0e6677320cc1161ee1dedd39ad
2023-12-06T11:53:41.8829197Z ❯ Found 0 files
2023-12-06T11:53:41.8830873Z ❯ Backfilling file list for commit: fb16c23bcc9c226bef7c7b9668b153d55f2d79e8
2023-12-06T11:53:42.1610846Z ❯ Found 0 files
2023-12-06T11:53:42.1611692Z ❯ Backfilling file list for commit: 1a893e691dc8c5671180dc895cb35275ea099993
2023-12-06T11:53:42.4828094Z ❯ Found 0 files
2023-12-06T11:53:42.4829109Z ❯ Backfilling file list for commit: 77ae9c267371e9d4a2d45567ac64118209072ee1
2023-12-06T11:53:42.7915196Z ❯ Found 0 files
2023-12-06T11:53:42.7916588Z ❯ Backfilling file list for commit: ba678cea9804148f88261381c12e9563a17107e8
2023-12-06T11:53:43.2193325Z ❯ Found 0 files
2023-12-06T11:53:43.2194252Z ❯ Backfilling file list for commit: c0b2e7df780a4a40b765ad28662952b53782ae81
2023-12-06T11:53:43.5105193Z ❯ Found 0 files
2023-12-06T11:53:43.5106171Z ❯ Backfilling file list for commit: 0ac8d5a5e20ffb323de7325804547a3e4f653007
2023-12-06T11:53:43.7957155Z ❯ Found 0 files
2023-12-06T11:53:43.7958333Z ❯ Backfilling file list for commit: 38251e842e4843b804c4798c9848c845f5bc8ba7
2023-12-06T11:53:44.0805577Z ❯ Found 0 files
2023-12-06T11:53:44.0806840Z ❯ Backfilling file list for commit: fc6455254682c8aedb1eae9379ad2fa92b45bc1a
2023-12-06T11:53:44.3720463Z ❯ Found 1 files
2023-12-06T11:53:44.3721783Z ❯ Backfilling file list for commit: 99253978d5bec148dc770d222470383f024d5937
2023-12-06T11:53:44.6575200Z ❯ Found 5 files
2023-12-06T11:53:44.6576127Z ❯ Backfilling file list for commit: a2e514c477ae8f61e33e18342ed2192271131e7f
2023-12-06T11:53:44.9518185Z ❯ Found 1 files
2023-12-06T11:53:44.9519158Z ❯ Backfilling file list for commit: 0b4ecc87d9d698dcb95a06fe802b96cca3a32b8d
2023-12-06T11:53:45.2339762Z ❯ Found 1 files
2023-12-06T11:53:45.2340727Z ❯ Backfilling file list for commit: bb772b9c7b13ee3387c1cb0049f820695398bd96
2023-12-06T11:53:45.5256193Z ❯ Found 2 files
2023-12-06T11:53:45.5257260Z ❯ Backfilling file list for commit: ac3b67360160ec13f53f4857d5c32b4bf08a153b
2023-12-06T11:53:45.8320877Z ❯ Found 1 files
2023-12-06T11:53:45.8321637Z ❯ Backfilling file list for commit: 3ba164b109d0d422c7a5c5d7c00e88b4fb02b3d3
2023-12-06T11:53:46.1289189Z ❯ Found 1 files
2023-12-06T11:53:46.1290859Z ✔ Needed bootstrapping, found configured bootstrapSha a6e3ed34fbfb2cf140f92ab23bf480a2e2f92040
2023-12-06T11:53:46.1291948Z ✔ Splitting 10 commits by path
2023-12-06T11:53:46.1298365Z ✔ No latest release found for path: ., component: , but a previous version (0.2.23) was specified in the manifest.
2023-12-06T11:53:46.1300409Z ✔ No latest release found for path: a-crate, component: a-crate, but a previous version (0.2.23) was specified in the manifest.
2023-12-06T11:53:46.1302271Z ✔ No latest release found for path: b-crate, component: b-crate, but a previous version (0.2.23) was specified in the manifest.
2023-12-06T11:53:46.1303341Z ✔ Building candidate release pull request for path: .
2023-12-06T11:53:46.1303852Z ❯ type: rust
2023-12-06T11:53:46.1304206Z ❯ targetBranch: main
2023-12-06T11:53:46.1363452Z ⚠ No latest release pull request found.
2023-12-06T11:53:46.1364070Z ❯ commits: 20
2023-12-06T11:53:46.1365639Z ✔ Considering: 20 commits
2023-12-06T11:53:46.1375830Z ❯ component: 
2023-12-06T11:53:46.1376617Z ❯ pull request title pattern: chore${scope}: release${component} ${version}
2023-12-06T11:53:46.2078645Z ⚠ No workspace manifest package name found
2023-12-06T11:53:46.2079672Z ✔ found workspace with 3 members, upgrading all
2023-12-06T11:53:46.2080578Z ❯ Fetching release-test/Cargo.toml from branch main
2023-12-06T11:53:46.2081559Z ❯ Fetching a-crate/Cargo.toml from branch main
2023-12-06T11:53:46.2082446Z ❯ Fetching b-crate/Cargo.toml from branch main
2023-12-06T11:53:46.2083209Z ✔ updating 3 submodules
2023-12-06T11:53:46.2089656Z ❯ versions map: Map(3) {
2023-12-06T11:53:46.2090329Z   'release-test' => Version {
2023-12-06T11:53:46.2090885Z     major: 0,
2023-12-06T11:53:46.2091532Z     minor: 3,
2023-12-06T11:53:46.2091997Z     patch: 0,
2023-12-06T11:53:46.2092449Z     preRelease: undefined,
2023-12-06T11:53:46.2093208Z     build: undefined
2023-12-06T11:53:46.2093705Z   },
2023-12-06T11:53:46.2094196Z   'a-crate' => Version {
2023-12-06T11:53:46.2094941Z     major: 0,
2023-12-06T11:53:46.2095404Z     minor: 3,
2023-12-06T11:53:46.2095824Z     patch: 0,
2023-12-06T11:53:46.2096502Z     preRelease: undefined,
2023-12-06T11:53:46.2097094Z     build: undefined
2023-12-06T11:53:46.2097560Z   },
2023-12-06T11:53:46.2098122Z   'b-crate' => Version {
2023-12-06T11:53:46.2098487Z     major: 0,
2023-12-06T11:53:46.2098779Z     minor: 3,
2023-12-06T11:53:46.2099151Z     patch: 0,
2023-12-06T11:53:46.2099864Z     preRelease: undefined,
2023-12-06T11:53:46.2100214Z     build: undefined
2023-12-06T11:53:46.2100607Z   }
2023-12-06T11:53:46.2100844Z }
2023-12-06T11:53:46.2101360Z ✔ Building candidate release pull request for path: release-test
2023-12-06T11:53:46.2102357Z ❯ type: rust
2023-12-06T11:53:46.2102746Z ❯ targetBranch: main
2023-12-06T11:53:46.2129553Z ❯ commits: 18
2023-12-06T11:53:46.2131556Z ✔ Considering: 18 commits
2023-12-06T11:53:46.2132037Z ❯ component: release-test
2023-12-06T11:53:46.2132631Z ❯ pull request title pattern: chore${scope}: release${component} ${version}
2023-12-06T11:53:46.2350249Z ✔ single crate found, updating Cargo.toml
2023-12-06T11:53:46.2352118Z ✔ Building candidate release pull request for path: a-crate
2023-12-06T11:53:46.2353354Z ❯ type: rust
2023-12-06T11:53:46.2354420Z ❯ targetBranch: main
2023-12-06T11:53:46.2414148Z ⚠ No latest release pull request found.
2023-12-06T11:53:46.2414953Z ❯ commits: 18
2023-12-06T11:53:46.2415773Z ✔ Considering: 18 commits
2023-12-06T11:53:46.2416474Z ❯ component: a-crate
2023-12-06T11:53:46.2417432Z ❯ pull request title pattern: chore${scope}: release${component} ${version}
2023-12-06T11:53:46.2535568Z ✔ single crate found, updating Cargo.toml
2023-12-06T11:53:46.2536737Z ✔ Building candidate release pull request for path: b-crate
2023-12-06T11:53:46.2537650Z ❯ type: rust
2023-12-06T11:53:46.2538396Z ❯ targetBranch: main
2023-12-06T11:53:46.2575683Z ❯ commits: 18
2023-12-06T11:53:46.2576557Z ⚠ No latest release pull request found.
2023-12-06T11:53:46.2578085Z ✔ Considering: 18 commits
2023-12-06T11:53:46.2579963Z ❯ component: b-crate
2023-12-06T11:53:46.2580995Z ❯ pull request title pattern: chore${scope}: release${component} ${version}
2023-12-06T11:53:46.2723380Z ✔ single crate found, updating Cargo.toml
2023-12-06T11:53:46.2725154Z ❯ running plugin: CargoWorkspace
2023-12-06T11:53:46.2727616Z ✔ Running workspace plugin
2023-12-06T11:53:46.2728586Z ✔ Found 4 in-scope releases
2023-12-06T11:53:46.2729239Z ✔ Building list of all packages
2023-12-06T11:53:46.2730517Z ❯ Fetching Cargo.toml from branch main
2023-12-06T11:53:46.2749663Z ❯ finding files by glob: release-test, ref: main, prefix: undefined
2023-12-06T11:53:46.2758784Z ❯ finding files by glob: a-crate, ref: main, prefix: undefined
2023-12-06T11:53:46.2760129Z ❯ finding files by glob: b-crate, ref: main, prefix: undefined
2023-12-06T11:53:46.2770615Z ✔ looking for candidate with path: release-test
2023-12-06T11:53:46.2771540Z ❯ Fetching release-test/Cargo.toml from branch main
2023-12-06T11:53:46.2773123Z ✔ looking for candidate with path: a-crate
2023-12-06T11:53:46.2774376Z ❯ Fetching a-crate/Cargo.toml from branch main
2023-12-06T11:53:46.2775792Z ✔ looking for candidate with path: b-crate
2023-12-06T11:53:46.2776799Z ❯ Fetching b-crate/Cargo.toml from branch main
2023-12-06T11:53:46.2777770Z ✔ looking for candidate with path: .
2023-12-06T11:53:46.2778524Z ❯ Fetching Cargo.toml from branch main
2023-12-06T11:53:46.2789337Z ⚠ package manifest at Cargo.toml is missing [package.name]
2023-12-06T11:53:46.2790365Z ✔ Building dependency graph for 3 packages
2023-12-06T11:53:46.2793524Z ✔ building graph order, existing package names: release-test,a-crate,b-crate
2023-12-06T11:53:46.2795844Z ❯ visiting release-test, path: 
2023-12-06T11:53:46.2797058Z ❯ marking release-test as visited and adding release-test to order
2023-12-06T11:53:46.2798399Z ❯ visiting a-crate, path: 
2023-12-06T11:53:46.2799482Z ❯ marking a-crate as visited and adding a-crate to order
2023-12-06T11:53:46.2800525Z ❯ visiting b-crate, path: 
2023-12-06T11:53:46.2801964Z ❯ marking b-crate as visited and adding b-crate to order
2023-12-06T11:53:46.2803017Z ✔ Updating 3 packages
2023-12-06T11:53:46.2803652Z ❯ package: a-crate
2023-12-06T11:53:46.2804459Z ❯ version: 0.3.0 from release-please
2023-12-06T11:53:46.2805262Z ❯ package: b-crate
2023-12-06T11:53:46.2805892Z ❯ version: 0.3.0 from release-please
2023-12-06T11:53:46.2806898Z ❯ package: release-test
2023-12-06T11:53:46.2807680Z ❯ version: 0.3.0 from release-please
2023-12-06T11:53:46.2809088Z ✔ Updating exising candidate pull request for a-crate, path: a-crate
2023-12-06T11:53:46.2825202Z ✔ Updating exising candidate pull request for b-crate, path: b-crate
2023-12-06T11:53:46.2833072Z ✔ Updating exising candidate pull request for release-test, path: release-test
2023-12-06T11:53:46.2842112Z ✔ Merging 3 in-scope candidates
2023-12-06T11:53:46.2844179Z ✔ Merging 3 pull requests
2023-12-06T11:53:46.2846955Z ⚠ pullRequestTitlePattern miss the part of '${scope}'
2023-12-06T11:53:46.2847888Z ⚠ pullRequestTitlePattern miss the part of '${component}'
2023-12-06T11:53:46.2848954Z ⚠ pullRequestTitlePattern miss the part of '${version}'
2023-12-06T11:53:46.2849714Z ✔ Post-processing 1 in-scope candidates
2023-12-06T11:53:46.2850554Z ❯ running plugin: Merge
2023-12-06T11:53:46.2851150Z ✔ Merging 1 pull requests
2023-12-06T11:53:46.2852436Z ⚠ pullRequestTitlePattern miss the part of '${scope}'
2023-12-06T11:53:46.2853326Z ⚠ pullRequestTitlePattern miss the part of '${component}'
2023-12-06T11:53:46.2854081Z ⚠ pullRequestTitlePattern miss the part of '${version}'
2023-12-06T11:53:47.4592730Z ✔ Looking for open release pull requests
2023-12-06T11:53:47.7905501Z ✔ found 1 open release pull requests.
2023-12-06T11:53:47.7906262Z ✔ Looking for snoozed release pull requests
2023-12-06T11:53:49.1284939Z ✔ found 0 snoozed release pull requests.
2023-12-06T11:53:49.1289003Z ❯ Fetching a-crate/CHANGELOG.md from branch main
2023-12-06T11:53:49.1292769Z ❯ Fetching a-crate/Cargo.toml from branch main
2023-12-06T11:53:49.1293834Z ⚠ file a-crate/Cargo.lock did not exist
2023-12-06T11:53:49.1294732Z ❯ Fetching a-crate/Cargo.lock from branch main
2023-12-06T11:53:49.1296075Z ❯ Fetching a-crate/clients/nodejs/package.json from branch main
2023-12-06T11:53:49.1297378Z ⚠ file a-crate/clients/nodejs/package.json did not exist
2023-12-06T11:53:49.1298502Z ⚠ file a-crate/clients/python/pyproject.toml did not exist
2023-12-06T11:53:49.1299888Z ❯ Fetching a-crate/clients/python/pyproject.toml from branch main
2023-12-06T11:53:49.1301198Z ❯ Fetching .release-please-manifest.json from branch main
2023-12-06T11:53:49.1302336Z ❯ Fetching b-crate/CHANGELOG.md from branch main
2023-12-06T11:53:49.1303688Z ❯ Fetching b-crate/Cargo.toml from branch main
2023-12-06T11:53:49.1304704Z ⚠ file b-crate/Cargo.lock did not exist
2023-12-06T11:53:49.1305652Z ❯ Fetching b-crate/Cargo.lock from branch main
2023-12-06T11:53:49.1306843Z ⚠ file b-crate/clients/nodejs/package.json did not exist
2023-12-06T11:53:49.1308123Z ❯ Fetching b-crate/clients/nodejs/package.json from branch main
2023-12-06T11:53:49.1309943Z ❯ Fetching b-crate/clients/python/pyproject.toml from branch main
2023-12-06T11:53:49.1311629Z ⚠ file b-crate/clients/python/pyproject.toml did not exist
2023-12-06T11:53:49.1312686Z ⚠ file release-test/Cargo.lock did not exist
2023-12-06T11:53:49.1313780Z ⚠ file release-test/clients/nodejs/package.json did not exist
2023-12-06T11:53:49.1315161Z ⚠ file release-test/clients/python/pyproject.toml did not exist
2023-12-06T11:53:49.1316356Z ❯ Fetching release-test/CHANGELOG.md from branch main
2023-12-06T11:53:49.1317472Z ❯ Fetching release-test/Cargo.toml from branch main
2023-12-06T11:53:49.1318698Z ❯ Fetching release-test/Cargo.lock from branch main
2023-12-06T11:53:49.1319915Z ❯ Fetching release-test/clients/nodejs/package.json from branch main
2023-12-06T11:53:49.1321361Z ❯ Fetching release-test/clients/python/pyproject.toml from branch main
2023-12-06T11:53:49.1322695Z ❯ Fetching Cargo.lock from branch main
2023-12-06T11:53:49.1323544Z ⚠ file Cargo.lock did not exist
2023-12-06T11:53:49.1324365Z ✔ Starting GitHub PR workflow...
2023-12-06T11:53:49.4189622Z ✔ Successfully found branch HEAD sha "197392a592e184e14fe596da2797444d14d4bed0".
2023-12-06T11:53:49.7129507Z ✔ Skipping branch creation step...
2023-12-06T11:53:49.9875418Z ✔ Got the latest commit tree
2023-12-06T11:53:50.3140553Z ✔ Successfully created a tree with the desired changes with SHA 1783c0ae8b88341d895154c2be19d70ceda5ab1d
2023-12-06T11:53:50.6956394Z ✔ Successfully created commit. See commit at https://api.github.com/repos/gabrik/release-learning-2/git/commits/fa82ff302094b5b99e6459abf803e050fd084322
2023-12-06T11:53:50.6958851Z ✔ Updating reference heads/release-please--branches--main to fa82ff302094b5b99e6459abf803e050fd084322
2023-12-06T11:53:51.1358281Z ✔ Successfully updated reference release-please--branches--main to fa82ff302094b5b99e6459abf803e050fd084322
2023-12-06T11:53:51.5032635Z ✔ Found existing pull request for reference gabrik:release-please--branches--main. Skipping creating a new pull request.

From the logs seems it fetches the files, but they are not updated. Any suggestion?

gabrik commented 9 months ago

I guess I solved it with this configuration of release-please:

{
    "release-type": "rust",
    "plugins": ["cargo-workspace"],
    "bootstrap-sha": "a6e3ed34fbfb2cf140f92ab23bf480a2e2f92040",
    "packages": {
        ".": {},
        "release-test":{},
        "a-crate":{},
        "b-crate":{},
        "clients/nodejs":{
            "release-type": "node"
        },
        "clients/python":{
            "release-type": "python"
        }
    },
    "pull-request-title-pattern":"chore${scope}: release${component} ${version}",
    "release-label": "Release Learning",
    "$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json"
}

I'll leave it there for anyone having a similar issue.