As per the title - It appears as if though the interface between release-please-action and release-please itself results in the signoff property being ignored.
Expected behavior
When migrating from v3 -> v4
Add the signoff key to my release-please-config.json file
Release please continues to signoff commits
Observed behavior
No commit signing appears to be happening
Action YAML
Happy to share this but it's mostly irrelevant. Heres the original release-please config after renovate updated us to v4 (we got some warning logs in the release-please task about unrecognised properties):
This might need to be an improvement in the release-please project but thought i'd raise it here as it has meant our upgrade to v4 has been unsuccessful.
TL;DR
As per the title - It appears as if though the interface between release-please-action and release-please itself results in the
signoff
property being ignored.Expected behavior
When migrating from v3 -> v4 Add the
signoff
key to myrelease-please-config.json
file Release please continues to signoff commitsObserved behavior
No commit signing appears to be happening
Action YAML
Happy to share this but it's mostly irrelevant. Heres the original release-please config after renovate updated us to v4 (we got some warning logs in the
release-please
task about unrecognised properties):Heres the two keys I added to the
release-please-config.json
as per the migration recommendationsAnd heres the release-please yaml post actioning the migration recommendations
Log output
No response
Additional information
Having done some digging..
The
Manifest
constructor expects thesignoff
property to be inmanifestOptions
(the 5th argument to the constructor) https://github.com/googleapis/release-please/blob/main/src/manifest.ts#L356When
fromManifest
is called it sets the 5th argument of the Manifest constructor to the following:manifestOptionOverrides
is only passed in by release-please-action in certain circumstancesmanifestOptions
comes from theparseConfig
function in release-pleaseThe
parseConfig
function does not extract thesignoff
property into theoptions
: https://github.com/googleapis/release-please/blob/main/src/manifest.ts#L1392-L1406This might need to be an improvement in the
release-please
project but thought i'd raise it here as it has meant our upgrade to v4 has been unsuccessful.