googleapis / release-please-action

automated releases based on conventional commits
Apache License 2.0
1.64k stars 207 forks source link

Labels are not being applied from config JSON #917

Open abhi-markan opened 8 months ago

abhi-markan commented 8 months ago

TL;DR

{
    "$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json",
    "packages": {
        ".": {}
    },
    "pull-request-title-pattern": "chore(${scope}): release${component} ${version}",
    "extra-label": "Type: chore, Type: Docs",
    "extra-files": [
        "CHANGELOG.md"
    ]
}

Above release-please-config.json does not allow inclusion or addition of custom labels specified.

Expected behavior

Expect the PR to have additional labels specified in the default config file.

Observed behavior

Custom user labels are not added to the label, rather standard autopending label is attached to the PR.

Action YAML

name: Automated release
run-name: Executing release on ${{ github.repository }} 🚀

on:
  push:
    branches: [main]

permissions:
  contents: write
  pull-requests: write

jobs:
  # 1. `package.json`, `README.md` and `CHANGELOG.md` updates
  release:
    name: Release setup 🔧
    runs-on: ubuntu-latest
    steps:
      - name: Release version ⚡️
        uses: google-github-actions/release-please-action@v4
        with:
          token: ${{ secrets.RELEASE_TOKEN }}
          release-type: node
          target-branch: main

Log output

No response

Additional information

No response

hwakabh commented 7 months ago

@abhi-markan Have you tried to Type: chore,Type: Docs ? Seems whitespace after comma will break fetching/creating of label, whereas implementations is simply using split(',') in here.

Following extra-label schema, I have same requirement as you, and it worked with the following release-please-config.json:

{
  "packages": {
    ".": {
      "release-type": "python"
    }
  },
  "draft-pull-request": true,
  "extra-label": "release,docs"
}