Open tamoreton opened 6 months ago
I can confirm the same behaviour. I have two repositories both configured with the following job
name: release
on:
push:
branches:
- main
permissions:
contents: write
pull-requests: write
jobs:
release-please:
runs-on: ubuntu-latest
steps:
- uses: google-github-actions/release-please-action@v4
with:
release-type: simple
skip-github-pull-request: true
On both repositories the release action completes successfully.
On the repository where there are only commits to the main branch without PRs CHANGELOG.md and version.txt are updated and a release is created.
However on the second repository where there is a merge commit from the action no files are updated and no release is created
I'm having the same behavior. When using skip-github-pull-request
basically nothing happen, either tag or releases are not created.
name: release-please
on:
push:
branches:
- main
- dev
permissions:
contents: write
pull-requests: write
jobs:
release:
if: ${{ github.ref == 'refs/heads/main' }}
runs-on: ubuntu-latest
steps:
- uses: google-github-actions/release-please-action@v4
with:
target-branch: ${{ github.ref_name }}
config-file: release-please-config.json
pre-release:
if: ${{ github.ref == 'refs/heads/dev' }}
runs-on: ubuntu-latest
steps:
- uses: google-github-actions/release-please-action@v4
id: pre-release
with:
target-branch: ${{ github.ref_name }}
config-file: release-please-dev-config.json
skip-github-pull-request: true
Same issue.
TL;DR
When using
release-please-action
withskip-github-pull-request: true
on amain
branch after a squash merge, no release is created despite the action completing successfully.Expected behavior
I expected
release-please-action
to create a new release and updateCHANGELOG.md
andpackage.json
with a new version after a PR titled with a Conventional Commit message was squash-merged intomain
.Observed behavior
The action completed successfully but did not create a new release, nor did it update
CHANGELOG.md
orpackage.json
. This occurred even though the squash-merged PR's title followed the Conventional Commits standard.Action YAML
Log output
Additional information
No response