Closed engeir closed 4 months ago
dmi3y
commented
5 months ago Confirming that, spent some time trying to figure out what's wrong with my config when adding extra-files. Switching to v3 fixes it by adding extra-files in the workflow config directly.
vuryss
commented
4 months ago I would also confirm. Prefixes like ci: do not trigger a release PR and do not appear in the changelog.
My release-please-config.json:
{
"packages": {
".": {
"changelog-path": "CHANGELOG.md",
"release-type": "simple",
"bump-minor-pre-major": false,
"bump-patch-for-minor-pre-major": false,
"draft": false,
"prerelease": false,
"changelog-sections": [
{
"type": "feat",
"section": "Features",
"hidden": false
},
{
"type": "fix",
"section": "Bug Fixes",
"hidden": false
},
{
"type": "perf",
"section": "Performance Improvements",
"hidden": false
},
{
"type": "revert",
"section": "Reverts",
"hidden": false
},
{
"type": "chore",
"section": "Miscellaneous Chores",
"hidden": false
},
{
"type": "docs",
"section": "Documentation",
"hidden": false
},
{
"type": "style",
"section": "Styles",
"hidden": false
},
{
"type": "refactor",
"section": "Code Refactoring",
"hidden": false
},
{
"type": "test",
"section": "Tests",
"hidden": false
},
{
"type": "build",
"section": "Build System",
"hidden": false
},
{
"type": "ci",
"section": "Continuous Integration",
"hidden": false
}
]
}
},
"changelog-sections": [
{
"type": "feat",
"section": "Features",
"hidden": false
},
{
"type": "fix",
"section": "Bug Fixes",
"hidden": false
},
{
"type": "perf",
"section": "Performance Improvements",
"hidden": false
},
{
"type": "revert",
"section": "Reverts",
"hidden": false
},
{
"type": "chore",
"section": "Miscellaneous Chores",
"hidden": false
},
{
"type": "docs",
"section": "Documentation",
"hidden": false
},
{
"type": "style",
"section": "Styles",
"hidden": false
},
{
"type": "refactor",
"section": "Code Refactoring",
"hidden": false
},
{
"type": "test",
"section": "Tests",
"hidden": false
},
{
"type": "build",
"section": "Build System",
"hidden": false
},
{
"type": "ci",
"section": "Continuous Integration",
"hidden": false
}
],
"$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json"
}
One of my colleagues found a weird way to make it work...
He removed the release-type: simple from the github action itself and he left it only inside the release-please-config.json as visible in the above example. Then all the types started to work and released are created.
The release type is STILL simple but it's ONLY defined in the config file, not in the release please github action yaml. That was the only change. We checked on multiple projects and confirmed it actually works. Why? No idea.
Kudos @arthurmoser
engeir
commented
4 months ago Thanks @vuryss! Got it working as well after removing everything except "token", "config-file" and "manifest-file" in the "with" block of the workflow file. Closing on this, as I see the README only specifies those three inputs when using config-file and manifest-file.
tongesy
commented
4 months ago After wasting too much time on this, I have it working like so for a node codebase:
Github action: release-please.yml
on:
push:
branches:
- main
permissions:
contents: write
pull-requests: write
name: Release Please
jobs:
release-please:
runs-on: ubuntu-latest
steps:
- uses: google-github-actions/release-please-action@v4
with:
token: ${{ secrets.RELEASE_PLEASE_TOKEN }}release-please-config.json
{
"$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json",
"packages": {
".": {
"changelog-path": "CHANGELOG.md",
"release-type": "node",
"changelog-sections": [
{ "type": "feat", "section": "🚀 New Features", "hidden": false },
{ "type": "feature", "section": "🚀 New Features", "hidden": false },
{ "type": "enhance", "section": "💅 Enhancements", "hidden": false },
{ "type": "fix", "section": "🔥 Bug Fixes", "hidden": false },
{ "type": "perf", "section": "🏃 Performance Improvements", "hidden": false },
{ "type": "revert", "section": "↩️ Reverts", "hidden": true },
{ "type": "docs", "section": "📚 Documentation", "hidden": false },
{ "type": "style", "section": "🎨 Code Style", "hidden": false },
{ "type": "chore", "section": "⚙️ Chores", "hidden": false },
{ "type": "refactor", "section": "⌨️ Code Refactoring", "hidden": false },
{ "type": "test", "section": "🧪 Automated Testing", "hidden": false },
{ "type": "build", "section": "🛠️ Build System", "hidden": false },
{ "type": "ci", "section": "📦 CI Improvements", "hidden": false }
]
}
}
}.release-please-manifest.json From what I understand in the docs, this is your initial release version
{
".": "1.0.0"
}
TL;DR
When using
google-github-actions/release-please-action@v4, specifying custom prefixes inrelease-please-config.jsonis not working, and instead the action ends in a "No user facing commits found since ... - skipping" message.Expected behavior
The action would create a PR when commiting with my custom prefixes, for example "chore", and extra files would be updated.
Observed behavior
No PR is made unless commit is "feat" etc., and README, which is specified as an extra file is never updated.
Action YAML
Log output
Additional information
No response