googleapis / release-please-action

automated releases based on conventional commits
Apache License 2.0
1.61k stars 207 forks source link

Separate pull requests not functioning as expected #964

Open Onurfesci opened 4 months ago

Onurfesci commented 4 months ago

TL;DR

When I have "separate-pull-requests": true in my release please config, it doesn't seem to track commits and manage release PRs correctly. I'm not sure if my configuration is wrong, or I misunderstood the manifest-driven documentation somehow.

Any help would be appreciated, I'm very confused about the correct configuration here...

My config:

{
  "packages": {
    "packages/aspire-icons": {},
    "packages/aspire-ui": {},
    "apps/email-templates": {},
    "apps/keycloak-theme": {},
    "apps/webapp-customer": {},
    "apps/webapp-marketing": {}
  },
  "separate-pull-requests": true
}

My manifest:

{
  "apps/email-templates": "1.1.1",
  "packages/aspire-ui": "1.0.0",
  "packages/aspire-icons": "1.0.0",
  "apps/webapp-customer": "1.1.0",
  "apps/keycloak-theme": "1.2.1",
  "apps/webapp-marketing": "1.0.0"
}

Expected behavior

Parse commits and bump versions for only the packages whose names are within the commit message parentheses i.e. fix(email-templates): bla bla should only bump apps/email-templates

Observed behavior

And the same with every other package in the monorepo.

However, sometimes when we merge large PRs with a bunch of commits, it updates the correct release PRs related to those commits.

Action YAML

on:
  push:
    branches:
      - main

permissions:
  contents: write
  pull-requests: write

name: Release Please

jobs:
  release-please:
    runs-on: ubuntu-latest
    steps:
      - uses: GoogleCloudPlatform/release-please-action@v4
        id: release
        with:
          token: ${{ secrets.RELEASE_TOKEN }}

Log output

No response

Additional information