googleapis / release-please

generate release PRs based on the conventionalcommits.org spec
https://www.conventionalcommits.org
Apache License 2.0
4.66k stars 350 forks source link

Keep non-conforming commits as undefined type #1331

Open mdvorak opened 2 years ago

mdvorak commented 2 years ago

Discussion for #1326

Conventional commits are great, but people make mistakes. Commits without conventional format got thrown away completely. This patch allows them to be displayed in Release Notes, and passed to a custom Release Notes generator as well. That way, information from those commits won't be lost during release.

Use-cases

Since it adds a new (by default) hidden type, change should not be breaking.

chingor13 commented 2 years ago

I think it's reasonable to parse non-conforming commits and let the downstream handlers (like changelog generators) decide whether or not to exclude them.

Implementation-wise, let's separate out the parsing of type-less commits from any new features that might use them (like a new custom changelog generator).

mdvorak commented 2 years ago

So what should be next steps? I'm willing to rework the PR as needed.