search

googleapis / ruby-spanner-activerecord

Spanner<->ActiveRecord adapter for Ruby
MIT License
87 stars 30 forks source link

fix: a few Ruby DSL schema dump bug fixes #308

Closed jarredhawkins closed 1 month ago

jarredhawkins commented 2 months ago

  1. Make sure array types are preserved in the dump Otherwise restoring from the dump, columns end up dropping the array type and coercing things to the base type

  2. Consistently sort storing data to avoid diffs in committed structure.rb file Right now it's dependent on the ordering of data from table_columns, which doesn't specify ordering.

google-cla[bot] commented 2 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

conventional-commit-lint-gcf[bot] commented 2 months ago

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot https://conventionalcommits.org/