googleapis / rules_gapic

Apache License 2.0
8 stars 11 forks source link

feat(bazel): stop generating php_grpc_library #159

Closed noahdietz closed 1 year ago

noahdietz commented 1 year ago

This stops generation of the php_grpc_library. The output of this target is not used in google-cloud-php. google-ads-php ships the generated output, but those BUILD.bazel files are built from a different tool.

Once this lands in googleapis, we will likely want to remove all php_grpc_library targets in packages we manage.

cc: @bshaffer

noahdietz commented 1 year ago

@alexander-fenster I need one more stamp from ya