search

googleapis / sample-tester

Tool for testing semantically equivalent samples in multiple languages and environments
Apache License 2.0
10 stars 12 forks source link

gen_manifest --flat ignores the first key/value pair #135

Open vchudnov-g opened 5 years ago

vchudnov-g commented 5 years ago

I suspect --flat consumes the next arguyment as a value, so in the example below the key foo never gets processed:

gen-manifest --flat  --foo="foofoo" --bar="barbar" --invocation="echo args='@args'" /tmp/quoted-args/getbook.py 
type: manifest/samples
schema_version: 3
samples:
- bar: barbar
  invocation: echo args='@args'
  path: /tmp/quoted-args/getbook.py
  sample: getbook_sample
hkdevandla commented 4 years ago

@vchudnov-g, this issue triggered out-of-slo. So checking to see if this really a p2. I assume passing "--flat" at the end just works fine (with no trailing arguments)? If that's the case, change this as p3?

hkdevandla commented 4 years ago

Perhaps, the underlying tool (sample-tester) is not active now i.e not used? @vchudnov-g, please advice.

vchudnov-g commented 4 years ago

Defined a 'P3' label and added it here.

vchudnov-g commented 2 years ago

Work on this repo is indefinitely paused at this moment.