search

googleapis / sdk-platform-java

Tooling and shared libraries for Cloud SDK for Java
https://cloud.google.com/java/docs/bom
Apache License 2.0
66 stars 54 forks source link

Add support for Micrometer Observation #2044

Open marcingrzejszczak opened 1 year ago

marcingrzejszczak commented 1 year ago

@blakeli0 suggested that I "move" the issue from https://github.com/googleapis/google-http-java-client/issues/1868#issuecomment-1736253372 over here.

We're more than happy to add support for instrumenting the Google Http Client with Micrometer Observation. If there's interest we can provide the PRs.

Initial PR to google client - https://github.com/googleapis/google-http-java-client/pull/1879

blakeli0 commented 1 year ago

@marcingrzejszczak Sorry if I didn't make it clear, we can keep all the discussion of adding Micrometer to google-http-java-client as they are. My suggestion was that, if you are interested in adding Micrometer to Google Cloud Client Libraries, this repo is the place to discuss it, and the discussion here would get more attention.

marcingrzejszczak commented 1 year ago

I see. Anyways, before I file a PR it would be good to know if there's any willingness to have the micrometer observation instrumentation added.