search

googleapis / sdk-platform-java

Tooling and shared libraries for Cloud SDK for Java
https://cloud.google.com/java/docs/bom
Apache License 2.0
62 stars 50 forks source link

showcase samples should be part of golden tests #2470

Open zhumin8 opened 5 months ago

zhumin8 commented 5 months ago

sample snippets here should be part of the golden testing for Showcase.

Steps to identify this:

rm -rf showcase/gapic-showcase/samples/
mvn clean install -DskipTests
cd showcase

then mvn compile -P update, expect the samples should be re-generated and added back. But this samples folder is not re-generated

blakeli0 commented 4 months ago

I think it worked before, could it be an issue caused by migrating Showcase to the hermetic build scrips? cc: @diegomarquezp @JoeWang1127

JoeWang1127 commented 4 months ago

Probably because we didn't copy sample directory in https://github.com/googleapis/sdk-platform-java/blob/main/showcase/scripts/generate_components.sh

lqiu96 commented 2 months ago

Keeping this a P2 issue. Seems to be due to a regression in the hermetic build scripts.