search

googleapis / sdk-platform-java

Tooling and shared libraries for Cloud SDK for Java
https://cloud.google.com/java/docs/bom
Apache License 2.0
64 stars 52 forks source link

Why didn't a check detect the inconsistent protobuf version 3.23.3 when the shared dependencies BOM had 3.23.2? #2621

Open suztomo opened 5 months ago

suztomo commented 5 months ago

Why didn't a check detect the inconsistent protobuf version 3.23.3 when the shared dependencies BOM had 3.23.2?

Detecting the discrepancy in java-cloud-bom is late https://github.com/googleapis/java-cloud-bom/actions/runs/8476531114/job/23226189124. That discrepancy should have been detected within this repository.

In the pull request https://github.com/googleapis/sdk-platform-java/pull/2570, Guava version was caught https://github.com/googleapis/sdk-platform-java/pull/2570#issuecomment-1998478633.

blakeli0 commented 1 week ago

@suztomo Which check are you referring to? Also the log in java-cloud-bom is not accessible anymore.

Separately, downgrading to P3 and change the type to feature request since this is a nice to have enhancement.