Paged Callables are not being Traced

googleapis / sdk-platform-java

Tooling and shared libraries for Cloud SDK for Java

https://cloud.google.com/java/docs/bom

Apache License 2.0

68 stars 53 forks source link

Paged Callables are not being Traced #2627

Open lqiu96 opened 7 months ago

lqiu96 commented 7 months ago

From gRPC's CallableFactory: https://github.com/googleapis/sdk-platform-java/blob/ba648ceac869d4fab1a9cbeb40f2e04f69dad4e3/gax-java/gax-grpc/src/main/java/com/google/api/gax/grpc/GrpcCallableFactory.java#L129-L139

Paged Callables do not have a TracedPagedCallable equivalent which implements tracing. It is possible that we can reused the TracedUnaryCallable, but that requires some investigation.

blakeli0 commented 7 months ago

We should add a TracedPagedCallable similar to TracedUnaryCallable, and test with Showcase

diegomarquezp commented 3 weeks ago

From discussion with @blakeli0, @zhumin8 and @lqiu96:

Tracing is implemented and tested in UnaryCallable. For a few other callables, Paging/Batching, we don’t have a use case for now.
This issue needs more investigation to determine how exactly do we want to trace paged callables in a transport-agnostic way.