search

googleapis / sdk-platform-java

Tooling and shared libraries for Cloud SDK for Java
https://cloud.google.com/java/docs/bom
Apache License 2.0
67 stars 54 forks source link

Downstream check should include changes from the generator #2685

Open blakeli0 opened 6 months ago

blakeli0 commented 6 months ago

We currently have downstream check that validates any changes in Gax or shared dependencies would not break downstream(java-bigtable etc.) libraries. However, it does not include changes from the generator, which caused the downstream libraries to fail. It happened recently for bigtable in the generator update PR. It was not possible to do so in the past due to BazelBot and Owlbot are not in this repo. Now that we have hermetic build, we can test downstream libraries with changes from the generator as well.

blakeli0 commented 6 months ago

@lqiu96 Feel free to add more info. cc: @JoeWang1127 @diegomarquezp