Migrate BaseSerializationTest to Junit 5 after downstream libraries migrate to Junit 5

googleapis / sdk-platform-java

Tooling and shared libraries for Cloud SDK for Java

https://cloud.google.com/java/docs/bom

Apache License 2.0

65 stars 52 forks source link

Migrate BaseSerializationTest to Junit 5 after downstream libraries migrate to Junit 5 #2763

Open JoeWang1127 opened 4 months ago

JoeWang1127 commented 4 months ago

BaseSerializationTest is extended in downstream libraries, e.g., java-logging, and these libraries still use Junit 4. Migrating this class to Junit 5 before downstream libraries will cause test failures in downstream libraries.

Related to #2726.

JoeWang1127 commented 4 months ago

Tests in java-storage also extend BaseSerializationTest.

Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:testCompile (default-testCompile) on project google-cloud-storage: Compilation failure
Error:  /home/runner/work/sdk-platform-java/sdk-platform-java/java-shared-dependencies/target/java-storage/google-cloud-storage/src/test/java/com/google/cloud/storage/SerializationTest.java:[369,3] method does not override or implement a method from a supertype