googleapis / sdk-platform-java

Tooling and shared libraries for Cloud SDK for Java
https://cloud.google.com/java/docs/bom
Apache License 2.0
60 stars 49 forks source link

chore: add iam logging #2932

Closed JoeWang1127 closed 1 week ago

JoeWang1127 commented 1 week ago

In this PR:

sonarcloud[bot] commented 1 week ago

Quality Gate Failed Quality Gate failed for 'gapic-generator-java-root'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
45.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

lqiu96 commented 1 week ago

Do you need to add in iam/logging to the proto_path for generation_config.yaml? https://github.com/googleapis/sdk-platform-java/blob/f58754178d16e5054326d78d1d372efe1408fa5e/generation_config.yaml#L40-L43

Or is that only for protos with services/ GAPICs. Not too familiar with hermetic build, going to default to Blake's review.

JoeWang1127 commented 1 week ago

Do you need to add in iam/logging to the proto_path for generation_config.yaml?

https://github.com/googleapis/sdk-platform-java/blob/f58754178d16e5054326d78d1d372efe1408fa5e/generation_config.yaml#L40-L43

Or is that only for protos with services/ GAPICs. Not too familiar with hermetic build, going to default to Blake's review.

No need to add a proto_path because logging is a nested directory in google/iam/v1 and all protos inside the proto_path should be generated by default.

I removed the special case in generate_library.sh so that this falls to the default case.