Closed JoeWang1127 closed 1 week ago
Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
45.5% Duplication on New Code (required ≤ 3%)
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Do you need to add in iam/logging to the proto_path for generation_config.yaml? https://github.com/googleapis/sdk-platform-java/blob/f58754178d16e5054326d78d1d372efe1408fa5e/generation_config.yaml#L40-L43
Or is that only for protos with services/ GAPICs. Not too familiar with hermetic build, going to default to Blake's review.
Do you need to add in iam/logging to the proto_path for generation_config.yaml?
Or is that only for protos with services/ GAPICs. Not too familiar with hermetic build, going to default to Blake's review.
No need to add a proto_path because logging is a nested directory in google/iam/v1
and all protos inside the proto_path should be generated by default.
I removed the special case in generate_library.sh
so that this falls to the default case.
In this PR:
google/iam/v1
.