googleapis / sdk-platform-java

Tooling and shared libraries for Cloud SDK for Java
https://cloud.google.com/java/docs/bom
Apache License 2.0
68 stars 54 forks source link

chore: re-generate when config or Dockerfile is changed #3146

Closed JoeWang1127 closed 2 months ago

JoeWang1127 commented 2 months ago

In this PR:

I use #3145 to verify the change.

diegomarquezp commented 2 months ago

LGTM. IIUC this is more generic than only allowing changes in the Dockerfile. I think this can allow modifications coming from anything that alters the output of the generation: postprocessing, gapic generator, Dockerfile, etc. And it's great to allow this btw, but maybe the title/description should be something like "re-generate when config or generation workflow has changed"?

From internal discussion with @JoeWang1127, this is wrong. There was a modification on what would allow the generation to start made in https://github.com/googleapis/sdk-platform-java/commit/74f20a253e65d9d4253541c4c8250d75abe8d0b8. So only the Dockerfile or the config yaml would trigger this.

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud