googleapis / sdk-platform-java

Tooling and shared libraries for Cloud SDK for Java
https://cloud.google.com/java/docs/bom
Apache License 2.0
68 stars 54 forks source link

chore: Remove cvss.proto in containeranalysis from being excluded. #3213

Closed blakeli0 closed 2 months ago

blakeli0 commented 2 months ago

The protoc generated files for cvss.proto are outdated for containeranalysis, we are going to update them in https://github.com/googleapis/google-cloud-java/pull/11155. This cvss.proto was exclude before because the whole v1beta1 version was not configured to be updated.

diegomarquezp commented 2 months ago
only in /home/runner/work/sdk-platform-java/sdk-platform-java/library_generation/test/resources/integration/golden/pom.xml
//project/build/plugins/plugin/version=3.1.3: 1
only in /home/runner/work/sdk-platform-java/sdk-platform-java/output/google-cloud-java/pom.xml
Generation finished successfully. Will now compare differences between generated and existing libraries
**************************************************
Checking for differences in 'java-apigee-connect'.
//project/build/plugins/plugin/version=3.1.2: 1

This doesn't look like it would be affected by this change. I retried it manually just in case.

diegomarquezp commented 2 months ago

Correction. The PR needs to be updated to the latest of main given the golden changes in https://github.com/googleapis/sdk-platform-java/pull/3211

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud