Mock tests are generated for mixin APIs when they probably shouldn't be

googleapis / sdk-platform-java

Tooling and shared libraries for Cloud SDK for Java

https://cloud.google.com/java/docs/bom

Apache License 2.0

65 stars 53 forks source link

Mock tests are generated for mixin APIs when they probably shouldn't be #790

Open noahdietz opened 3 years ago

noahdietz commented 3 years ago

I was just testing a change to build_gen to introduce the Location pkg deps when the mixin is present and noticed in the generated output that MockLocations.java and MockLocationsImpl.java. I'm not sure that these should be generated since there isn't a Locations client generated, but I will let you @miraleung decide.

noahdietz commented 3 years ago

You can repro with cl/384991546 bazel build //google/cloud/datastream/v1alpha1:google-cloud-datastream-v1alpha1-java

miraleung commented 3 years ago

Thanks, earmarking for Fixit.