googleapis / storage-testbench

A testbench for Google Cloud Storage client libraries.
Apache License 2.0
9 stars 19 forks source link

fix: map 504 errors to DEADLINE_EXCEEDED #663

Closed tritone closed 1 month ago

tritone commented 1 month ago

This is needed to test behavior with DEADLINE_EXCEEDED errors for gRPC. GCS is still returning these errors in some cases for internal timeouts so we need to be able to test this.

Fixes #

It's a good idea to open an issue first for discussion.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.68%. Comparing base (61bce3c) to head (5e40848). Report is 29 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #663 +/- ## ========================================== - Coverage 98.69% 98.68% -0.01% ========================================== Files 50 50 Lines 8492 8461 -31 ========================================== - Hits 8381 8350 -31 Misses 111 111 ``` | [Flag](https://app.codecov.io/gh/googleapis/storage-testbench/pull/663/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=googleapis) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/googleapis/storage-testbench/pull/663/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=googleapis) | `98.68% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=googleapis#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.