googleapis / synthtool

Apache License 2.0
87 stars 85 forks source link

Enable no-floating-promises for eslint #1809

Open feywind opened 1 year ago

feywind commented 1 year ago

The purpose of this proposal is to prevent accidentally "dangling" promises from called functions.

https://typescript-eslint.io/rules/no-floating-promises

In Node, it's possible to call an async function, or one that just returns a promise, and ignore the result. This leaves a promise that has no catch handler, which, in modern runtimes, can result in crashing the process.

The proposal here is two-fold:

We might also consider this related rule:

https://typescript-eslint.io/rules/no-misused-promises