Open diegomarquezp opened 7 months ago
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge
label. Good luck human!
-- conventional-commit-lint bot https://conventionalcommits.org/
@diegomarquezp Can you build (docker build) owlbot postprocessor with this pull request and run the container against java-storage and java-bigtable to see everything is fine? Add observation in the pull request description.
@suztomo At a glance, this will affect the repos depending on synthtool (maybe java-bigtable will complain about missing files). I was planning to leave this branch as parallel to the main branch until we roll out the new postprocessor.
That said, I'll give a try to using the postprocessor with this image
@suztomo I added observations of a local run of this image against java-bigtable
and java-storage
. They look OK.
Nice. What needs to happen before merging this?
Once our hermetic build scripts are live, we will merge this PR
I just read this. Wait for the hermetic build script then.
Memo to myself: ensure no repositories, including ones outside 2-week release cycle, depend on the old container image.
Our transferred owlbot implementation will contain the java templates currently contained in synthtool. This branch (more specifically, its HEAD commit) will be used by our hermetic build scripts.
I'm planning to leave this as an alternative branch used by the hermetic build scripts in sdk-platform-java since merging it will likely break HW libraries or the monorepo. Once our hermetic build scripts are live, we will merge this PR
Testing locally
Building the image
Testing in
java-bigtable
Testing in
java-storage