search

googleapis / synthtool

Apache License 2.0
87 stars 82 forks source link

ci: automatic kokoro label in and /gcbrun comment #1965

Closed suztomo closed 2 months ago

suztomo commented 3 months ago

From reading the configuration (https://github.com/googleapis/repo-automation-bots/pull/1682/files), it accepts multiple objects.

blakeli0 commented 3 months ago

Do we expect this change to be propagated to all libraries through Owlbot PRs?

suztomo commented 3 months ago

Do we expect this change to be propagated to all libraries through Owlbot PRs?

Yes.

blakeli0 commented 3 months ago

Do we expect this change to be propagated to all libraries through Owlbot PRs?

Yes.

Thanks! I don't see this file trusted-contribution.yml in google-cloud-java, is it excluded in some steps?

suztomo commented 2 months ago

I don't see this file trusted-contribution.yml in google-cloud-java, is it excluded in some steps?

There's no OwlBot configuration for google-cloud-java any more https://github.com/googleapis/google-cloud-java/tree/main/.github. Thus the postprocessor does not run.

suztomo commented 2 months ago

Experiment succeeded in https://github.com/googleapis/java-bigtable/pull/2233#issuecomment-2145392263

blakeli0 commented 2 months ago

I don't see this file trusted-contribution.yml in google-cloud-java, is it excluded in some steps?

There's no OwlBot configuration for google-cloud-java any more https://github.com/googleapis/google-cloud-java/tree/main/.github. Thus the postprocessor does not run.

We only recently removed the OwlBot configuration, but this file was introduced years ago, so this file should at least exist in google-cloud-java. Just like in java-bigtable, this file exists but a few new configs are added by this change.

suztomo commented 2 months ago

The file was not there before the monorepo migraiton https://github.com/googleapis/google-cloud-java/tree/main_202208/.github.

so this file should at least exist in google-cloud-java

What observations made you think that?

suztomo commented 2 months ago

The postprocessor had been running, but owlbot-java has special treatment not to process the root directory of google-cloud-java.