Out of order defines. - Githubissues

googlearchive / IMD

An AMD-compatible module registry for use with HTML Imports

73 stars 24 forks source link

Out of order defines. #18

Closed llamadonica closed 7 years ago

llamadonica commented 7 years ago

I tried to add tests
Not sure if we should make define(...) return Promise. I didn't do it because so far you were using clean ES5 that works everywhere

googlebot commented 7 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

llamadonica commented 7 years ago

:/ Goin to close and reopen.