Making changes to better support service worker registration as input

googlearchive / Propel

A library to support developers implementing Web Push notifications

Other

196 stars 22 forks source link

Making changes to better support service worker registration as input #45

Closed gauntface closed 8 years ago

gauntface commented 8 years ago

Fixes #30

@wibblymat @jeffposnick @petele

This change should implement the changes we discussed in #30 regarding requiring a worker URL or Registration in the constructor.

I've added a constant for error messages so they are easier to handle in the tests with changes, although still not easily shareable by just importing a file because the push-client is transpiled the tests in the browser are not (so no easy way I can think of to require in a file) - Thoughts on this would be super helpful.

gauntface commented 8 years ago

FYI Tests are failing but seems to be a problem with Travis VM + Google Chrome Install (i.e. no browser to run the tests in).

wibblymat commented 8 years ago

:+1: