search

googlearchive / Propel

A library to support developers implementing Web Push notifications
Other
196 stars 27 forks source link

What happens if I'm using a SW for caching already? #63

Open owencm opened 8 years ago

owencm commented 8 years ago

I presume here we register the SW when the client is created, is there anything to worry about if I'm using it on my site where I already have a sw toolbox worker?

gauntface commented 8 years ago

You can pass in a registration object in to the constructor and we'll just use that.

This is a good candidate for the ReadMe.

Also need to do a doc sweep to fix bad docs: http://googlechrome.github.io/Propel/releases/0.0.20/class/src/client/push-client.js~PushClient.html#instance-constructor-constructor

addyosmani commented 8 years ago

Created a docs label we can reuse for these items. I was also curious about whether passing in the registration object was the pattern we wanted to call out to folks and would value seeing docs around this land.

gauntface commented 8 years ago

Thanks Addy. Docs review is high on my list not that we have version-ed docs auto-building and deploying.