googlearchive / TemplateBinding

TemplateBinding Prolyfill
290 stars 61 forks source link

esprima is breaking AMD loaders #105

Closed neonstalwart closed 11 years ago

neonstalwart commented 11 years ago

if an AMD loader is added before polymer.js, then esprima tries to register itself as an AMD module. using dojo's AMD loader this will break the loader because it is receiving a call to define that it was not expecting. see http://jsbin.com/ayemib/1/edit for an example.

fyi - i'm using the master branch and i can work around this by adding the AMD loader after polymer.

arv commented 11 years ago

You should always load polymer first or the shadow dom polyfill will not work correctly.

Still, we should remove the ADM loader header if it is broken.

rafaelw commented 11 years ago

My bad. Removed: https://github.com/Polymer/mdv/commit/84752bde240a7f6c8d8328f4485ede56606db087