googlearchive / TemplateBinding

TemplateBinding Prolyfill
290 stars 61 forks source link

template if not working inside table #209

Closed jakemac53 closed 9 years ago

jakemac53 commented 9 years ago

See http://jsbin.com/sewisujiru/3/edit?html,output. Neither row is visible, when one should be. Interestingly if you remove the tds from inside the trs they both become visible.

jmesserly commented 9 years ago

pure TemplateBinding repro: http://jsbin.com/leredonusu/1/edit?html,output

it does not bootstrap correctly. bootstrap'd HTML looks like:

      <template>
        <table>
          <tbody><template><tr if="{{falseItem}}"><td>Should be invisible</td></tr></template>
          <template><tr if="{{trueItem}}"><td>Should be visible</td></tr></template>
        </tbody></table>
      </template>

note that the "if" should be on the "template" not on the "tr".

jakemac53 commented 9 years ago

ah, nice find :)

mysticatea commented 9 years ago

I guess, #194 will be fixed by this PR?

jakemac53 commented 9 years ago

yes, I just added a note there