search

googlearchive / TemplateBinding

TemplateBinding Prolyfill
290 stars 61 forks source link

broken demo? #71

Closed albell closed 11 years ago

albell commented 11 years ago

Sorry, this is probably a painfully noobish question but I watched the Google i/o video, got all psyched, downloaded the repo, downloaded canary, enabled the Experimental Javascript flag, opened the tic tac toe demo page in place (locally) but I get nothing, just console errors:

Uncaught ReferenceError: PathObserver is not defined template_element.js:559
Uncaught TypeError: Object function HTMLTemplateElement() { [native code] } has no method 'forAllTemplatesFrom_' view_controller.js:37

ditto for the twitter demo. What am I missing? In the explanatory sample all the code is concatenated into a single file. Do I have to run some build step myself to even fool around with a demo? Any help appreciated.

-stumped

dfreedm commented 11 years ago

Did you check out the submodules? PathObserver is defined in the ChangeSummary submodule Run git submodule update --init --recursive from the top of MDV repo.

rafaelw commented 11 years ago

Yup. Making sure you have all the submodules. I'm closing this bug, but please re-open if you've got all the code and the examples are still failing.