search

googlearchive / TemplateBinding

TemplateBinding Prolyfill
290 stars 61 forks source link

<template ref> fails inside of shadow DOM #72

Closed rafaelw closed 11 years ago

rafaelw commented 11 years ago

ref needs to check the local tree.

rafaelw commented 11 years ago

Fixed here: https://github.com/Polymer/mdv/commit/7de0697e318bb001e1649005ec48eb294edad6e4

arodic commented 11 years ago

I tried running this code with rebuilt platform.js including this fix 7de0697 but it didn't seem to fix the problem. Also, using polymer.js from the master branch didn't fix it either. Are there any other files needed for this fix?

rafaelw commented 11 years ago

Well done. You discovered (at least) two other bugs. Re-opening.

rafaelw commented 11 years ago

Found and fixed: https://github.com/Polymer/mdv/issues/91

rafaelw commented 11 years ago

Fixed #2 :https://github.com/Polymer/mdv/issues/92

rafaelw commented 11 years ago

@arodic thanks for finding. You're example works with the last two fixes in. Keep it up!

arodic commented 11 years ago

Nice! Works great. Thanks for fixing @rafaelw!