search

googlearchive / TemplateBinding

TemplateBinding Prolyfill
290 stars 55 forks source link

abandonInstances is never called #9

Closed arv closed 11 years ago

arv commented 11 years ago

I don't remember what this is supposed to do that clear doesn't?

rafaelw commented 11 years ago

Yeah. Probably nothing useful. In the C++ impl, this was called synchronously when a template was ripped out. There's no way to do this in the async impl. The big piece of work here is to implement template iteration in terms of mutation_summary and have it's behavior be consistent with a fully async model.

rafaelw commented 11 years ago

BTW, Adam & I have ideas about this (including quite a good one from Tab), but this is one of those things that are probably worth whiteboarding together.

arv commented 11 years ago

I'll rip out the code for now then.

On Tue, Feb 5, 2013 at 12:40 PM, rafaelw notifications@github.com wrote:

BTW, Adam & I have ideas about this (including quite a good one from Tab), but this is one of those things that are probably worth whiteboarding together.

— Reply to this email directly or view it on GitHubhttps://github.com/toolkitchen/mdv/issues/9#issuecomment-13141633.

erik

arv commented 11 years ago

07ed4f5c54ff50d754b9d670ace6a77f2e50ed43