search

googlearchive / android-BluetoothLeGatt

Migrated:
https://github.com/android/connectivity
Apache License 2.0
924 stars 589 forks source link

Ask for permissions in the new permissions style #41

Closed fmatosqg closed 7 years ago

fmatosqg commented 7 years ago

Work done by @dzwiedziu-nkg (PR #20) which was based on work by @prof18 (PR #16).

I simply worked on removing the merge conflict that came from Application/build.gradle and gradle/wrapper/gradle-wrapper.properties. That meant dropping the changes from previous commits in favor of the latest origin master from google. Followed by testing on Android O preview 3 (nexus 6p).

I signed the CTA (https://cla.developers.google.com/ ).

googlebot commented 7 years ago

So there's good news and bad news.

:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

:confused: The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

fmatosqg commented 7 years ago

@dzwiedziu-nkg Your consent is needed :)

dzwiedziu-nkg commented 7 years ago

What I can do? My cla is filled and signed and I no see any consent request, antyhing.

fmatosqg commented 7 years ago

@dzwiedziu-nkg Merging with your fork should work, closing this PR as I see it's already done.