googlearchive / android-BluetoothLeGatt

Migrated:
https://github.com/android/connectivity
Apache License 2.0
924 stars 589 forks source link

Show `ProgressDialog` while reconnecting to a device from the `DeviceControlActivity` #9

Closed tfKamran closed 5 years ago

tfKamran commented 8 years ago

Fixes issue #8


This change is Reviewable

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


tfKamran commented 8 years ago

I've already signed it, if not my email account, then at least my GitHub username should have matched.

mitchross commented 8 years ago

@tfKamran you need to reply "I signed it!"

ryanseys commented 8 years ago

No, some of the commits just don't have an email (you can see this by seeing the commits aren't associated with an email in the commits panel of this PR).

Or just look at https://github.com/googlesamples/android-BluetoothLeGatt/commit/3556ca61044c4ddf49317c0ab9c8c4897e1657c9.patch and see that the commit doesn't have an email in the From field.

screen shot 2016-03-21 at 1 47 53 pm
codingjeremy commented 5 years ago

I am closing this issue/PR, as it has been migrated to the new repo linked above in the comments. Thank you!