search

googlearchive / android-FingerprintDialog

Migrated:
https://github.com/android/security
Apache License 2.0
1.38k stars 477 forks source link

Using Dependency Injection #29

Closed EugeneHoran closed 8 years ago

EugeneHoran commented 8 years ago

The fingerprint examples are good but I think it is bad practice to use Dependency Injections in a Google Sample(or any open-source sample). I am assuming most developers are not using DI in their applications or familiar with them (especially new developers). It is also recommended not to use DI frameworks. https://developer.android.com/training/articles/memory.html#DependencyInjection. Although it simplifies the code for the creator, it complicates code for individuals like myself that don't use DI.

thagikura commented 8 years ago

Thanks for the suggestion. The code internally already removed the DI dependency. That will be reflected to this repository anytime soon.

thagikura commented 8 years ago

This is now fixed.