search

googlearchive / android-audio-high-performance

We now recommend you use the Oboe libraries:
https://github.com/google/oboe
Apache License 2.0
719 stars 275 forks source link

No c++ compiler optimizations? #98

Closed rpattabi closed 5 years ago

rpattabi commented 6 years ago

These samples meant for high performance audio are excellent. Considering the emphasis on high performance, why aren't there any compiler optimizations used in these samples?

Lazy guy like me, would take this as template to build our apps. So it is essential to include appropriate compiler optimizations as well.

This will also help me understand which of the plethora of the flags are appropriate in the context of android such as -O3

dturner commented 6 years ago

Great suggestion.

I'm thinking we should have a Debug configuration which uses -O0 and a Release configuration which uses -Ofast. I will update the CMakeLists.txt accordingly.

ggfan commented 6 years ago

probably check for the default compile options Gradle ( Android Studio ) is using for debug and release build; ndk samples are based on that assumption ( release build will use the best optimization for performance )

rpattabi commented 6 years ago

@ggfan Did a quick look. The c++ / ndk project generated by Android Studio 3.0.1 does not specify any optimization. So is the case with some of the google samples.

ggfan commented 6 years ago

thanks! then we really need to add the best -O options inside CMakeLists.txt.

codingjeremy commented 5 years ago

This sample has been deprecated/archived (check README for more information on newer samples related to this technology).

As recommended by GitHub, we are closing all issues and pull requests.