googlearchive / android-instant-apps

Migrated:
https://github.com/android/app-bundle
Apache License 2.0
846 stars 277 forks source link

Lifecycle Fragments #25

Closed nicholaspark09 closed 7 years ago

nicholaspark09 commented 7 years ago

It doesn't seem that the LifecycleFragment actually works in feature modules. I don't think I'm the only one with the issue or if this is the right channel to be posting on. :/

keyboardsurfer commented 7 years ago

Maybe this issue over on the Google Issuetracker can help you.

nicholaspark09 commented 7 years ago

I think it should at least be mentioned somewhere in the documentation as our company is looking to use instant apps in tandem with viewmodels

keyboardsurfer commented 7 years ago

It is documented in the new configurations section of the gradle plugin.

api: The dependency is available to the module at compile time, and it's also available to the consumer of the module at compile time and runtime. This configuration behaves just like compile (which is now deprecated), and you should typically use this only in library modules. App modules should use implementation, unless you want to expose its API to a separate test module.