Feature custom app - Githubissues

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

keyboardsurfer commented 7 years ago

Hi and thanks for this pull request. You're making quite some changes to this sample. Before diving into this, could you please explain what this sample shows and why it is necessary? For future reference: It's advisable to first open an issue and discuss an addition on such a scale first.

keyboardsurfer commented 7 years ago

I'm closing this pull request for now. If you feel like this should be merged please re-open and comment.

CedrickFlocon commented 7 years ago

Hi, Its was just a poc to test if we can use a custom app inside an Instant App. This is related to this issue

googlearchive / android-instant-apps

Feature custom app #28