googlearchive / android-instant-apps

Migrated:
https://github.com/android/app-bundle
Apache License 2.0
846 stars 277 forks source link

multi-feature-module uses api instead of implementation #35

Closed mustafaberkaymutlu closed 6 years ago

mustafaberkaymutlu commented 6 years ago

The Android documentation says feature modules should use "implementation" instead of "api" while adding base module in their dependencies.

"The two individual feature modules use the implementation project expression within their dependencies block"

All samples that have base modules use "implementation" but multi-feature-module sample uses "api" in here and here.

keyboardsurfer commented 6 years ago

Thanks for reporting this issue. It'll be fixed with the next sample release.

keyboardsurfer commented 6 years ago

Shipped with today's release.