googlearchive / angularfire-seed

Seed project for AngularFire apps
http://angularfire.com
MIT License
410 stars 191 forks source link

Seed to fit Angular teams new recommended file structure #61

Closed douglascorrea closed 9 years ago

douglascorrea commented 9 years ago

As @katowulf said in #25 I´m opening this new issue to adapt this seed to the new Structure in the original https://github.com/angular/angular-seed

katowulf commented 9 years ago

I just looked over the angular-seed project and I'm not seeing any significant variations here (other than the fact that we have a test/ directory and the have moved test/e2e into e2e-tests/.

Can you elaborate on what you would like to see changed here?

katowulf commented 9 years ago

It looks like the test files have moved into the app/ directory? Is that the major difference?

douglascorrea commented 9 years ago

Hi @katowulf,

Actually the structure is different from the previous because it is separating code by components (modules) that could be reusable, it is stored in app/components. One folder by component/module.

It also separates each partial in its indiviual directory, then we store controller and specs for each partial separatelly.

It is following this recommendation: https://docs.google.com/document/d/1XXMvReO8-Awi1EZXAXS4PzDzdNvV6pGcuaF4Q9821Es/mobilebasic?pli=1

Another generator that follows this recomendations is https://github.com/cgross/generator-cg-angular

katowulf commented 9 years ago

So based on this recommendation, I think this structure looks good?

/app/components
    authentication/
        services.js
        services.spec.js
        decorators.js
        decorators.spec.js
        directives.js
        directives.spec.js
    routing/
        security.js
        security.spec.js
    fbutils/
        fbutils.js
            fbutils.spec.js
/app/view-home
    home.js
    home.html
    home.spec.js
/app/view-login
    login.js
    login.html
    login.spec.js
/app/view-account
    account.js
    account.html
    account.spec.js
/app/view-chat
    chat.js
    chat.html
    chat.spec.js 
douglascorrea commented 9 years ago

@katowulf exactly! It is perfect!

oshko commented 9 years ago

Great! Is there any time table of newer version?

katowulf commented 9 years ago

Fixed in 1.0.0