search

googlearchive / angularfire-seed

Seed project for AngularFire apps
http://angularfire.com
MIT License
409 stars 191 forks source link

Changing angularfire and mockfirebase dependencies to 0.9.0 and ~0.7.0 #64

Closed chinedufn closed 9 years ago

chinedufn commented 9 years ago

fixes #63

dbuentello commented 9 years ago

TLDR: using angularfire 0.9.0 fixes one issue but creates another. Solutions:

  1. Use release versions (not tested but should work)
  2. Wait till repos (really just waiting for angularfire to be published to bower) are finished being released.
  3. Remove angularfire from bower.json and build from angularfire@master (tested and verified)

Im assuming your using latest commit (dd6e4a046fa4110988ef2802870eb34b57d5389f). The issues are a result of the repos being mid-release and out of sync. Once angularfire 0.9.1 is out then the prefered signature for auth.$createUser will be an object (the way the code was written).

dbuentello commented 9 years ago

You just caught the repo at a bad time :smile:

See efa895e2088dd4597769d389cc6e2206dd230883

chinedufn commented 9 years ago

Great thanks I will close this then

makeitrein commented 9 years ago

Noob question, but how does one "build from angularfire@master "? Would love to use the latest version of this branch, just not sure how to get the right version of angular fire.

dbuentello commented 9 years ago

Follow the directions for setting up angularfire-seed as written in the README with one adjustment. After cloning the repo and before executing npm install, open up the bower.json file and remove the angularfire dependency. You can follow the rest of the guide as is.

The next step is to build angularfire yourself and place the dist/ folder generated in the correct location so that the index.html from angularfire-seed can get to it.

index.html

  <script src="bower_components/angular/angular.js"></script>
  <script src="bower_components/angular-route/angular-route.js"></script>
  <script src="bower_components/firebase/firebase.js"></script>
  <script src="bower_components/firebase-simple-login/firebase-simple-login.js"></script>
  <script src="bower_components/angularfire/dist/angularfire.js"></script>

Building angularfire is the easiest...you can use their contributing instructions with a minor modification 

$ git clone https://github.com/firebase/angularfire.git
$ cd angularfire            # go to the angularfire directory
$ npm install -g grunt-cli  # globally install grunt task runner
$ npm install -g bower      # globally install Bower package manager
$ npm install               # install local npm build / test dependencies
$ bower install             # install local JavaScript dependencies
$ grunt build               # will generate build and place them under dist/

Hope this helps.

makeitrein commented 9 years ago

@dbuentello - thanks for the quick reply! Trying out your instructions now...