search

googlearchive / angularfire-seed

Seed project for AngularFire apps
http://angularfire.com
MIT License
410 stars 191 forks source link

Remove all references to deprecated Firebase Simple Login #74

Closed jwngr closed 9 years ago

jwngr commented 9 years ago

We want people to upgrade to the latest version of Firebase with the latest and greatest authentication methods and it having Simple Login sprinkled throughout the README and the code is causing confusion for some users.

kjhughes commented 9 years ago

Seeking clarification on the code update part of the issue: While this commit migrated angularfire-seed to the new authentication methods, it did so by modifying app/js/simpleLogin.js without changing its name. The issue here is to eliminate use of the name 'simpleLogin' because it connotes association with the deprecated Firebase Simple Login library?

jwngr commented 9 years ago

Yes, you are exactly right. This is using the newest auth methods, but the naming is the confusing thing for people, myself included. Ideally we would not use the phrase "Simple Login" at all in this repo, including in filenames, variable names, and comments.

djindjic commented 9 years ago

oh yes, I agree with that. I'm not very deep in angularfire but I currently have a problem with login and wanted to ask is it old simple login or just name convection. So, this is new auth method and just file named simpleLogin.js?

jwngr commented 9 years ago

Yes, it is the new methods with the old name. We will fix this.

katowulf commented 9 years ago

Remove anything prefixed with "simple" in 1.0.0 to avoid confusion.