updated to firebase-3.6.5 and angularfire-2.2.0

googlearchive / angularfire-seed

Seed project for AngularFire apps

http://angularfire.com

MIT License

410 stars 191 forks source link

updated to firebase-3.6.5 and angularfire-2.2.0 #98

Open mkobar opened 7 years ago

mkobar commented 7 years ago

I needed this badly for an angular 1 project I'm working on, so I thought I would update this seed to 2.x.

I have moved the API Keys to a private.js file (which is in .gitignore), but the private-dummy.js sample is included. And the components/firebase.utils/firebase.utils.js can now be removed, as it is no longer used or referenced.

This currently is running (and hosted on) Firebase here: https://angularfire-seed-2.firebaseapp.com/

I have updated the project.json and bower.json but have not touched or updated the test files.

Please let me know any issues encountered and let me know how to sign the CLA.

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

mkobar commented 7 years ago

CLA has been submitted

googlebot commented 7 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

katowulf commented 7 years ago

Thanks for sending this over! Really appreciate it when people contribute back. Upgrading to the latest Firebase SDK does feel appropriate.

katowulf commented 7 years ago

Looks like the test units failed : (

mkobar commented 7 years ago

yes, I'm sure that all the test scripts / packages and test javascript files need to be updated too.

I guess I'll work on that next.