Defer adding polyfill script tag until body is defined.

googlearchive / app-drawer-template

Application template that demonstrates the PRPL pattern

28 stars 22 forks source link

Defer adding polyfill script tag until body is defined. #5

Closed justinfagnani closed 8 years ago

justinfagnani commented 8 years ago

Since there's already a 'load' event handler, I just combined the two.

justinfagnani commented 8 years ago

@kevinpschaaf I didn't see #3 which is a simpler fix, but not sure if there's advantages to this approach. Your choice! :)

atishpatel commented 8 years ago

I believe this approach makes it so 'webcomponents-lite.min.js' isn't being fetched until after load so it would lead to performance loss while the other one doesn't have that con.

JosefJezek commented 8 years ago

Use this script https://github.com/PolymerElements/polymer-starter-kit/blob/psk2/index.html#L34-L65

kevinpschaaf commented 8 years ago

Closing, merged #3.