Code Review: *jasvir/v8-benchmark@2735 | jasvir | 2008-10-21 16:31:49 -0800 (Tue, 21 Oct 2008)

[kpreid]

Original issue 861 created by jasvir on 2008-10-22T00:35:08.000Z:

Description:

• Adds the V8 benchmark to caja
• Changes <cajole> tags to be transforms that take as argument the target language (js, valija, cajita) and how to render them (minified)
• Removes extraneous \w from html-sanitizer

Affected Paths: M //trunk/build.xml M //trunk/src/com/google/caja/plugin/BuildServiceImplementation.java M //trunk/src/com/google/caja/plugin/html-sanitizer.js M //trunk/src/com/google/caja/tools/AbstractCajaAntTask.java D //trunk/src/com/google/caja/tools/CajoleAntTask.java M //trunk/src/com/google/caja/tools/GenRuleAntTask.java M //trunk/src/com/google/caja/tools/InnocentAntTask.java M //trunk/src/com/google/caja/tools/MinifyAntTask.java A //trunk/src/com/google/caja/tools/TransformAntTask.java A //trunk/tests/com/google/caja/demos/benchmarks A //trunk/tests/com/google/caja/demos/benchmarks/BenchmarkRunner.java A //trunk/third_party/java/bsf A //trunk/third_party/java/bsf/LICENSE.txt A //trunk/third_party/java/bsf/README.txt A //trunk/third_party/java/bsf/bsf.jar A //trunk/third_party/js/v8-benchmark A //trunk/third_party/js/v8-benchmark/LICENSE A //trunk/third_party/js/v8-benchmark/README.txt A //trunk/third_party/js/v8-benchmark/base.js A //trunk/third_party/js/v8-benchmark/crypto.js A //trunk/third_party/js/v8-benchmark/deltablue.js A //trunk/third_party/js/v8-benchmark/earley-boyer.js A //trunk/third_party/js/v8-benchmark/raytrace.js A //trunk/third_party/js/v8-benchmark/richards.js A //trunk/third_party/js/v8-benchmark/run.html A //trunk/third_party/js/v8-benchmark/run.js A //trunk/third_party/js/v8-benchmark/v8-logo.png

[kpreid]

Comment #1 originally posted by jasvir on 2008-10-22T21:58:42.000Z:

Snapshot jasvir/v8-benchmark@2746

• changed the varz variable so size, debugging, and language specific (cajita/valija) tests can be added
• changed comments in myvn so eclipse tests don't run benchmarks (which are time consuming)

[kpreid]

Comment #2 originally posted by jasvir on 2008-10-23T21:25:04.000Z:

<empty>

[kpreid]

Comment #3 originally posted by metaweta on 2008-10-23T23:17:04.000Z:

Comments on r2735.

[kpreid]

Comment #4 originally posted by jasvir on 2008-10-24T00:33:25.000Z:

Snapshot

[kpreid]

Comment #5 originally posted by metaweta on 2008-10-24T21:21:19.000Z:

BenchmarkRunner.java 25: terminate comment (did you recompile?) Otherwise LGTM.

[kpreid]

Comment #6 originally posted by jasvir on 2008-10-24T23:02:15.000Z:

<empty>