search

googlearchive / chromedeveditor

Chrome Dev Editor is a developer tool for building apps on the Chrome platform - Chrome Apps and Web Apps, in JavaScript or Dart. (NO LONGER IN ACTIVE DEVELOPMENT)
BSD 3-Clause "New" or "Revised" License
2.92k stars 413 forks source link

Add file_handlers capability for source code files #389

Open ussuri opened 10 years ago

ussuri commented 10 years ago

We should open at least for .dart, and possibly for .js, .json, .html, *.css, etc. This is especially important on and applicable to ChromeOS.

ovangle commented 10 years ago

I'll take this one, I was working on it already when I was told not to implement #450

ussuri commented 10 years ago

Great, thanks.

devoncarew commented 10 years ago

To be clear, this issue is (I believe) to add support for opening files directly into Spark from ChromeOS, and for opening the files on the command-line for other OSes.

Essentially, listening for additional data on an onLaunched event.

ovangle commented 10 years ago

Oh, sorry, that was a misunderstanding on my part -- I'm an idiot :). Do you want me to get rid of what I've already done and implement this or extend it to implement this?

If all the file handlers have to be known in advance then at least I can get rid of the registry singleton, which only existed to handle the possibility of having the user load unknown files into the app and then configure them as if they were known to the application at compile time.

ovangle commented 10 years ago

Also -- how would I go about testing such functionality? I obviously don't have access to a ChromeOS environment, and I don't know how to parse command line arguments when launching a chrome app in any environment I do have access to (linux).

devoncarew commented 10 years ago

I think the work to implement this would largely be orthogonal to your pull request :( so a new pull request makes sense to me. I think the work would look something like:

I'm not sure about testing. @ussuri @dinhviethoa ?

ussuri commented 9 years ago

We are no longer positioning CDE as a single file editor, rather as a project-oriented IDE, so opening a single file fits poorly into this vision. If the status quo ever changes, we'll revisit this idea.