⭐️ Allow dynamic config files

googlearchive / ci-runner

27 stars 6 forks source link

⭐️ Allow dynamic config files #49

Closed samccone closed 9 years ago

samccone commented 9 years ago

q: Does this allow arbitrary remote code execution¿ -- yes
q: Does this matter since others can not use this CI¿ -- I do not think so :palm_tree:
q: why do we need this¿ -- project specific dynamic config -- see https://github.com/PolymerElements/polymer-starter-kit/pull/384

samccone commented 9 years ago

@ajklein any thoughts around this?

This is actually causing PSK some problems at the moment

dfreedm commented 9 years ago

Yeah, I'm not going to allow arbitrary code execution on the CI runner.

samccone commented 9 years ago

is anyone else using the CI box outside of us¿

dfreedm commented 9 years ago

Anyone can make a pull request to any repo to have it run on the CI server. This means that arbitrary people could use the CI to run arbitrary code if we allowed arbitrary code, which I'm not going to let happen.

samccone commented 9 years ago

ok thanks for the responses