googlearchive / cloud-functions-emulator

A local emulator for deploying, running, and debugging Google Cloud Functions.
https://github.com/GoogleCloudPlatform/cloud-functions-emulator/wiki
Apache License 2.0
827 stars 115 forks source link

Allow emulator work work on node version ^6 #282

Closed ThePaulMcBride closed 6 years ago

ThePaulMcBride commented 6 years ago

Fixes #267

The restriction on the node version seems unnecessary. This causes issues with the firebase tool packages which relies on this.

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
ThePaulMcBride commented 6 years ago

I signed it!

googlebot commented 6 years ago

CLAs look good, thanks!

ThePaulMcBride commented 6 years ago

Can I get some feedback here? This is an issues that is causing a lot of confusion to Firebase users.

jmdobry commented 6 years ago

Superseded by #287