search

googlearchive / core-ajax

Polymer Core Ajax
26 stars 52 forks source link

Remove bad status check in isSuccess #60

Closed bearfriend closed 9 years ago

bearfriend commented 9 years ago

See https://github.com/Polymer/core-ajax/issues/58

The return statement that I modified seems like it shouldn't be necessary to be any more complicated than the one step that I left. The !status was causing any status equal to 0 to return true.

googlebot commented 9 years ago

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

bearfriend commented 9 years ago

Signed!

googlebot commented 9 years ago

CLAs look good, thanks!

addyosmani commented 9 years ago

Change LGTM - we're dropping that !0 issue that was evaluating to true. cc @garlicnation in case this needs to be backed out.

garlicnation commented 9 years ago

Thanks addy!